Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix max title length #180

Merged
merged 3 commits into from
Apr 2, 2024
Merged

fix: fix max title length #180

merged 3 commits into from
Apr 2, 2024

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Feb 10, 2024

Fix #179

@wa0x6e wa0x6e requested a review from ChaituVR February 10, 2024 19:48
ChaituVR
ChaituVR requested changes Feb 21, 2024
View reviewed changes
src/providers/walletconnectNotify.ts Outdated Show resolved Hide resolved
@wa0x6e wa0x6e requested a review from ChaituVR April 1, 2024 08:02
@codecov Codecov
Copy link

codecov bot commented Apr 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 5.55556% with 17 lines in your changes are missing coverage. Please review.

Files Patch % Lines
src/providers/walletconnectNotify.ts 0.00% 12 Missing ⚠️
src/helpers/utils.ts 16.66% 5 Missing ⚠️
Additional details and impacted files

📢 Thoughts on this report? Let us know!

ChaituVR
ChaituVR requested changes Apr 1, 2024
View reviewed changes
src/providers/walletconnectNotify.ts Outdated Show resolved Hide resolved
ChaituVR
ChaituVR approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@wa0x6e wa0x6e merged commit fe66706 into master Apr 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChaituVR ChaituVR ChaituVR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: title: Validation error: length [{"value": String("Implementation of New Discord Roles for Enhanc...
2 participants
@wa0x6e @ChaituVR