Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add retries #53

Open
wa0x6e opened this issue Apr 25, 2023 · 0 comments
Open

feat: add retries #53

wa0x6e opened this issue Apr 25, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@wa0x6e
Copy link
Contributor

wa0x6e commented Apr 25, 2023

Issues

Webhook sent to subscribers who are not able to receive them for any reasons are just lost.

Solution

Add a retry strategy, so failed webhook requests can be retried.

How

BullMq queue system sees to be the obvious solution, as the tool has been created to handle this kind of scenarios.

More questions before starting

Which retry strategy should we use ?

  • fixed time between each retry
  • exponential backoff strategy (longer time between each subsequent retry)
  • other

When to stop retrying ?

How may times/long should we retry ?

What happens to events that still fail, after all the retry attempts ?

  • Just discard them
  • Save them somewhere, so we can fire them again on user demand
@wa0x6e wa0x6e self-assigned this Apr 26, 2023
@wa0x6e wa0x6e added the enhancement New feature or request label Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant