Upgrading Snapshot's EIP4824 daoURI implementation

[thelastjosh]

Hi folks,

After discussion a month ago (sorry for the delay!) with @bonustrack , posting an issue here to organize efforts to upgrade and finalize the current EIP4824 daoURI implementation. For examples, see https://hub.snapshot.org/api/eip4824/balancer.eth/ or https://hub.snapshot.org/api/eip4824/opcollective.eth/

I will continue to edit this issue to update the expected behavior over the next week or two.

Expected behavior

• None of the subsidiary URIs (membersURI, proposalsURI, activityLogURI, or contractsURI return well-formed URLs. In particular, there is an extra / when appending the right information.
• Changes to membersURI including pagination, uniqueness checks, etc. which is already underway at improve membersURI #812
• Changes to contractsURI including clarifying the meaning of the address currently displayed there (is it always the main governance token, or is it just the address associated to ENS name? can we parse Snapshot's data to add other contract addresses)
• Change "@context": "<http://www.daostar.org/schemas>", everywhere to "@context": ["https://www.snapshot.org", https://www.daostar.org/schemas"],
• Snapshot needs to publish an issuerURI as specified in DAOIP-3, as technically all 4824-compliant data being published through the Snapshot Hub is an attestation from Snapshot. That is, absent a DAO "claiming" this data by referencing it in their own daoURI, indexers will want to be able to distinguish information that Snapshot publishes about a DAO from information that DAOs publish themselves. I will create a separate PR for this.

Actual behavior

None of the above currently happens.

Steps to reproduce the behavior

Note, this issue is also referenced in the DAOstar GitHub at metagov/daostar#205 and related issues linked there.

[Rashmi-278]

Updated the PR to reflect Fabian's comments, #812

[Rashmi-278]

@thelastjosh

None of the subsidiary URIs (membersURI, proposalsURI, activityLogURI, or contractsURI return well-formed URLs. In particular, there is an extra / when appending the right information.

Could you please share more details on the expected behavior for this? Do you main trailing '/' on the URL? They work without the trailing slash

Snapshot needs to publish an issuerURI as specified in DAOIP-3, as technically all 4824-compliant data being published through the Snapshot Hub is an attestation from Snapshot. That is, absent a DAO "claiming" this data by referencing it in their own daoURI, indexers will want to be able to distinguish information that Snapshot publishes about a DAO from information that DAOs publish themselves. I will create a separate PR for this.

Please assign this PR to me when you create it

[Rashmi-278]

Context updated: Check here