Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: enforce start date higher or equal to creation date for proposal #334

Open
bonustrack opened this issue Jun 15, 2022 · 3 comments · Fixed by #335
Open

bug: enforce start date higher or equal to creation date for proposal #334

bonustrack opened this issue Jun 15, 2022 · 3 comments · Fixed by #335
Assignees
@Todmy

Comments

@bonustrack
Copy link
Member

No description provided.

@bonustrack bonustrack changed the title Enforce start date higher or equal to creation date Enforce start date higher or equal to creation date for proposal Jun 15, 2022
@bonustrack bonustrack mentioned this issue Jun 15, 2022
Merged
@ChaituVR
Copy link
Member

ChaituVR commented Jun 15, 2022 •
edited by samuveth
Loading

Reverted the change, as we need UI to handle this

  • On the hub, We should have a buffer time like 15 secs (?)
  • On UI start should be the same as timestamp if Now is selected on the timestamp (@samuveth Can you confirm if it is possible? considering the end timestamp)
  • Check if it creates a problem on snapshot-relayer (while creating proposals from gnosis safe)

@ChaituVR ChaituVR reopened this Jun 15, 2022
@samuveth
Copy link
Contributor

@ChaituVR Oh I misread this the first time. Thought it was for start > end. I will create a PR with a fix today

@samuveth samuveth mentioned this issue Jun 16, 2022
Closed
@zzuziak
Copy link
Contributor

zzuziak commented Jan 30, 2023

Hello @ChaituVR @samuveth what's the status of this issue?

@bonustrack bonustrack changed the title Enforce start date higher or equal to creation date for proposal bug: enforce start date higher or equal to creation date for proposal May 1, 2023
@Todmy Todmy self-assigned this Jun 13, 2023
This was referenced Jun 13, 2023
Merged
Closed
@Todmy Todmy mentioned this issue Jun 22, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Todmy Todmy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fabien/start date snapshot-labs/snapshot-hub
5 participants
@Todmy @ChaituVR @bonustrack @zzuziak @samuveth