Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings for old spaces don't show up. #291

Open
mktcode opened this issue Apr 1, 2022 · 3 comments
Open

Settings for old spaces don't show up. #291

mktcode opened this issue Apr 1, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@mktcode
Copy link
Contributor

mktcode commented Apr 1, 2022

https://snapshot.org/#/uniswap/settings

Seems like settings aren't accessible for spaces that haven't been set up with an ENS domain.

Isn't it possible to migrate those spaces? Maintaining backwards compatibility is probably more work.

@mktcode mktcode added the bug Something isn't working label Apr 1, 2022
@samuveth
Copy link
Contributor

samuveth commented Apr 2, 2022

@bonustrack can you shed some light on this. I thought we already changes all existing spaces to ENS

@bonustrack
Copy link
Member

@samuveth We don't, to do the migration we need to contact these spaces and show some notice on the UI. I've ever recommended Uniswap to change to ENS without success.

@mktcode
Copy link
Contributor Author

mktcode commented Apr 3, 2022

My first thought was that migration should maybe be enforced at some point, with a notice on the UI. "Old space setups are deprecated. Please move to an ENS setup until ....". But then I was struggling to see what benefits it really has. To my understanding signatures for votes and proposals is all it needs from the technical side. Everything else should be focused on providing the best possible user experience. Feels like the ENS approach stands in our way a little bit in that regard.

Apart from that... the current issue should be fixed of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants