Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social attributes should be stored in an array #276

Open
bonustrack opened this issue Mar 16, 2022 · 1 comment
Open

Social attributes should be stored in an array #276

bonustrack opened this issue Mar 16, 2022 · 1 comment

Comments

@bonustrack
Copy link
Member

Currently we store "github" and "twitter", "website" on the space settings with their own field like this

{
  twitter: 'abc',
  github: 'def',
  website: 'https://',
  ...
}

When adding new social link we always need to update the space settings structure, we should instead have a generic way to store attributes like this:

{
  attributes: [
    { id: 'twitter', value: 'abc' },
    { id: 'github', value: 'def' },
    { id: 'website', value: 'https://' }
  ]
  ...
}

and use that to store Twitter GitHub and others that we want to add on the way like Discord Telegram CoinGecko.

Before

@zzuziak
Copy link
Contributor

zzuziak commented Feb 8, 2023

Hey @bonustrack, still valid? Could be potentially part of the cooldown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants