feat: add bump and tag version workflow #11
Conversation
|
But a new tag will be already created with #13 right? |
|
No, #13 only create a github release, this pr bump version and creates the tag |
|
I see 😄 then better to keep everything in a single action, don't see when we will use these separately, would be nice to have a single action that can take care of everything, maybe we can use an input field to find out if it is minor update or major update |
.github/workflows/bump-version.yml
Outdated
| - name: Automated Version Bump | ||
| id: version-bump | ||
| uses: phips28/gh-action-bump-version@master | ||
| with: | ||
| tag-prefix: ${{ inputs.tag-prefix }} | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
This need GITHUB token? better to use https://github.com/snapshot-labs/snapshot.js/blob/master/.github/workflows/update-minor-version.yml#L17 easy to understand
There was a problem hiding this comment.
This one just open a PR. The point of this PR is to do everything all a once, at the same time.
|
Single action is #14 |
|
|
||
| jobs: | ||
| bump-version: | ||
| name: Bump Version on master |
There was a problem hiding this comment.
This action will have permission to merge to master.? 🤔
There was a problem hiding this comment.
It works on regular branch. But just tested, and it does not work on protected branch, it requires a Personal Access Token, instead of GITHUB_TOKEN
|
These actions do not seem to work well with protected branch. Maybe explore a more all in one solution such as release it |
Add a new workflow which will:
Fix #9