From 9d577dac4528d6f5d39dd7f6467bcd392b57a2f1 Mon Sep 17 00:00:00 2001 From: Silvio Moreto Date: Wed, 4 Sep 2013 12:13:30 -0300 Subject: [PATCH] Pull Request Guidelines --- CONTRIBUTING.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 45cbde5d6..e064f3663 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -73,3 +73,13 @@ Feature requests are welcome. But take a moment to find out whether your idea fits with the scope and aims of the project. It's up to *you* to make a strong case to convince the project's developers of the merits of this feature. Please provide as much detail and context as possible. + +## Pull Request Guidelines + +* Please **do not** use `var _this = this`. Use `$.proxy` instead to keep the context. +* Submit your CLA, if you haven't. +* Please check to make sure that there aren't existing pull requests attempting to address the issue mentioned. We also recommend checking for issues related to the issue on the tracker, as a team member may be working on the issue in a branch or fork. +* Non-trivial changes should be discussed in an issue first +* If possible, use JSlint or JSHint to validate it +* If possible, add relevant tests to cover the change +* Write a convincing description of your PR and why we should land it