Skip to content

Commit f1f1233

Browse files
authored
Fix faulty layout implementation of preAuth hint (APPS-1605) (#192)
1 parent 8b2660d commit f1f1233

File tree

3 files changed

+17
-11
lines changed

3 files changed

+17
-11
lines changed

docs/pull_request_template.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11

2+
APPS-
23

34
### How to test?
45

@@ -9,7 +10,7 @@
910
- [ ] All requirements of the issue are fulfilled
1011
- [ ] Changelog is updated
1112
- [ ] Documentation is updated
12-
- [ ] [Self-Review](https://www.nerdwallet.com/blog/engineering/why-you-should-be-doing-self-reviews/))_
13+
- [ ] [Self-Review](https://www.nerdwallet.com/blog/engineering/why-you-should-be-doing-self-reviews/)
1314
- [ ] Review with the Product Owner _(Release-Variante o. Minified Build)_
1415

1516
#### App Tests

ui/src/main/java/io/snabble/sdk/ui/payment/PayoneInputView.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ import android.webkit.WebChromeClient
1111
import android.webkit.WebResourceRequest
1212
import android.webkit.WebView
1313
import android.webkit.WebViewClient
14-
import android.widget.FrameLayout
1514
import android.widget.ProgressBar
15+
import android.widget.RelativeLayout
1616
import android.widget.TextView
1717
import android.widget.Toast
1818
import androidx.annotation.Keep
@@ -53,7 +53,7 @@ import java.util.Locale
5353
import java.util.concurrent.CancellationException
5454

5555
class PayoneInputView @JvmOverloads constructor(context: Context, attrs: AttributeSet? = null, defStyleAttr: Int = 0) :
56-
FrameLayout(context, attrs, defStyleAttr), LifecycleEventObserver {
56+
RelativeLayout(context, attrs, defStyleAttr), LifecycleEventObserver {
5757

5858
private lateinit var webView: WebView
5959
private lateinit var progressBar: ProgressBar
Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,31 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<merge xmlns:android="http://schemas.android.com/apk/res/android"
3+
xmlns:tools="http://schemas.android.com/tools"
34
android:layout_width="match_parent"
4-
android:layout_height="match_parent">
5+
android:layout_height="match_parent"
6+
tools:parentTag="android.widget.RelativeLayout">
57

68
<TextView
79
android:id="@+id/threed_secure_hint"
810
android:layout_width="match_parent"
911
android:layout_height="wrap_content"
10-
android:textAppearance="?attr/textAppearanceBodyMedium"
11-
android:padding="16dp" />
12+
android:padding="16dp"
13+
android:textAppearance="?attr/textAppearanceBodyMedium" />
1214

1315
<WebView
1416
android:id="@+id/web_view"
15-
android:layout_below="@+id/threed_secure_hint"
1617
android:layout_width="match_parent"
17-
android:layout_height="match_parent" />
18+
android:layout_height="match_parent"
19+
android:layout_alignWithParentIfMissing="true"
20+
android:layout_below="@+id/threed_secure_hint" />
1821

1922
<ProgressBar
20-
android:layout_width="match_parent"
21-
android:layout_height="wrap_content"
2223
android:id="@+id/progress"
2324
style="?android:attr/progressBarStyleHorizontal"
25+
android:layout_width="match_parent"
26+
android:layout_height="wrap_content"
27+
android:layout_marginTop="-7dp"
2428
android:visibility="gone"
25-
android:layout_marginTop="-7dp"/>
29+
tools:visibility="visible" />
30+
2631
</merge>

0 commit comments

Comments
 (0)