do not allow maxSizeMM to be bigger than the view itself

Author: ajungg

ui/src/main/java/io/snabble/sdk/ui/checkout/CheckoutOfflineView.java

@@ -3,6 +3,7 @@
 import android.annotation.SuppressLint;
 import android.content.Context;
 import android.graphics.Bitmap;
+import android.graphics.Rect;
 import android.util.AttributeSet;
 import android.util.DisplayMetrics;
 import android.view.Gravity;
@@ -48,6 +49,7 @@ public class CheckoutOfflineView extends FrameLayout implements Checkout.OnCheck
     private View upArrow;
     private CodeListViewAdapter viewPagerAdapter;
     private boolean isSmallDevice;
+    private View viewPagerContainer;
 
     public CheckoutOfflineView(Context context) {
         super(context);
@@ -72,11 +74,6 @@ private void init() {
 
         maxSizeMm = options.maxSizeMm;
 
-        // too large, use normal scaling too save memory
-        if (maxSizeMm > 100) {
-            maxSizeMm = 0;
-        }
-
         encodedCodesGenerator = new EncodedCodesGenerator(options);
 
         paidButton = findViewById(R.id.paid);
@@ -111,6 +108,8 @@ public void click() {
         upArrow = findViewById(R.id.arrow);
 
         viewPager = findViewById(R.id.view_pager);
+        viewPagerContainer = findViewById(R.id.view_pager_container);
+
         viewPagerAdapter = new CodeListViewAdapter();
         viewPager.setAdapter(viewPagerAdapter);
         viewPager.registerOnPageChangeCallback(new ViewPager2.OnPageChangeCallback() {
@@ -148,8 +147,6 @@ public void onPageSelected(int position) {
             checkoutId.setVisibility(View.GONE);
         }
 
-        project.getAssets().get("checkout-offline", this::setHelperImage);
-
         checkout = SnabbleUI.getProject().getCheckout();
         onStateChanged(checkout.getState());
     }
@@ -174,6 +171,8 @@ protected void onLayout(boolean changed, int left, int top, int right, int botto
                     project.getAssets().get("checkout-offline", this::setHelperImage);
                 });
             }
+
+            viewPagerAdapter.notifyDataSetChanged();
         }
     }
 
@@ -279,15 +278,25 @@ public ViewHolder onCreateViewHolder(@NonNull ViewGroup parent, int viewType) {
         public void onBindViewHolder(@NonNull ViewHolder holder, int position) {
             int margin = Math.round(16 * getResources().getDisplayMetrics().density);
             if (maxSizeMm > 0) {
-                // TODO what if maxSizeMm is bigger than screen?
                 DisplayMetrics dm = getResources().getDisplayMetrics();
                 float pixelsPerMmX = dm.xdpi / 25.4f;
+
                 int size = (int) (pixelsPerMmX * maxSizeMm);
+                Rect rect = new Rect();
+                viewPagerContainer.getGlobalVisibleRect(rect);
+
+                int w = rect.width();
+                int h = rect.height();
+
+                if (size > w || size > h) {
+                    size = ViewGroup.LayoutParams.MATCH_PARENT;
+                }
 
                 FrameLayout.LayoutParams lp = new FrameLayout.LayoutParams(
                         ViewGroup.LayoutParams.MATCH_PARENT,
                         size,
                         Gravity.CENTER);
+
                 lp.leftMargin = margin;
                 lp.rightMargin = margin;
                 holder.barcodeView.setLayoutParams(lp);

ui/src/main/res/layout/snabble_view_checkout_offline.xml

@@ -12,6 +12,7 @@
         android:layout_marginTop="16dp"
         android:layout_marginLeft="16dp"
         android:layout_marginRight="16dp"
+        android:layout_alignParentTop="true"
         android:orientation="vertical">
 
         <ImageView
@@ -43,12 +44,17 @@
             android:textSize="17sp"/>
     </LinearLayout>
 
-    <androidx.viewpager2.widget.ViewPager2
-        android:id="@+id/view_pager"
+    <FrameLayout
+        android:id="@+id/view_pager_container"
         android:layout_width="match_parent"
         android:layout_height="match_parent"
         android:layout_below="@+id/helper_container"
-        android:layout_above="@+id/checkout_id" />
+        android:layout_above="@+id/checkout_id">
+        <androidx.viewpager2.widget.ViewPager2
+            android:id="@+id/view_pager"
+            android:layout_width="match_parent"
+            android:layout_height="match_parent" />
+    </FrameLayout>
 
     <TextView
         android:id="@+id/checkout_id"