Fixed leaks of background threads

Author: ajungg

build.gradle

@@ -24,7 +24,7 @@ allprojects {
     }
 
     project.ext {
-        sdkVersion='0.8.3'
+        sdkVersion='0.8.4'
         versionCode=1
 
         compileSdkVersion=28

ui/src/main/java/io/snabble/sdk/ui/scanner/BarcodeView.java

@@ -39,7 +39,6 @@ public class BarcodeView extends AppCompatImageView {
     private boolean adjustBrightness = true;
 
     private Handler uiHandler;
-    private Handler backgroundHandler;
     private int backgroundColor;
 
     public BarcodeView(Context context) {
@@ -60,10 +59,6 @@ public BarcodeView(Context context, AttributeSet attrs, int defStyleAttr) {
     private void init(Context context, AttributeSet attrs) {
         uiHandler = new Handler(Looper.getMainLooper());
 
-        HandlerThread handlerThread = new HandlerThread("BarcodeView");
-        handlerThread.start();
-        backgroundHandler = new Handler(handlerThread.getLooper());
-
         if (attrs != null) {
             TypedArray arr = context.getTheme().obtainStyledAttributes(
                     attrs, R.styleable.BarcodeView, 0, 0);
@@ -155,6 +150,9 @@ private void generate() {
                 height = h;
                 generatedText = text;
 
+                final HandlerThread handlerThread = new HandlerThread("BarcodeView");
+                handlerThread.start();
+                final Handler backgroundHandler = new Handler(handlerThread.getLooper());
                 backgroundHandler.post(new Runnable() {
                     @Override
                     public void run() {
@@ -220,6 +218,8 @@ public void run() {
                                 }
                             });
                         }
+
+                        handlerThread.quit();
                     }
                 });
             }

ui/src/main/java/io/snabble/sdk/ui/search/SearchableProductAdapter.java

@@ -28,12 +28,13 @@ public enum SearchType {
         FOLDED_NAME
     }
 
+    private static Handler backgroundHandler;
+    private Handler uiHandler;
+
     private OnProductSelectedListener productSelectedListener;
     private SearchType searchType = SearchType.FOLDED_NAME;
     private ProductDatabase productDatabase;
     private Cursor cursor;
-    private Handler backgroundHandler;
-    private Handler uiHandler;
     private CancellationSignal cancellationSignal;
     private int itemCount = 0;
     private boolean showBarcode = true;
@@ -46,9 +47,11 @@ public SearchableProductAdapter() {
     public SearchableProductAdapter(ProductDatabase productDatabase) {
         this.productDatabase = productDatabase;
 
-        HandlerThread handlerThread = new HandlerThread("SearchableProductAdapter");
-        handlerThread.start();
-        backgroundHandler = new Handler(handlerThread.getLooper());
+        if(backgroundHandler == null) {
+            HandlerThread frameProcessingThread = new HandlerThread("SearchableProductAdapter");
+            frameProcessingThread.start();
+            backgroundHandler = new Handler(frameProcessingThread.getLooper());
+        }
 
         uiHandler = new Handler(Looper.getMainLooper());
     }