Change StateFlow to SharedFlow to fix emitting issues (APPS-1648) (#218)

Author: cmaier

CHANGELOG.md

@@ -7,6 +7,10 @@ All notable changes to this project will be documented in this file.
 ### Removed
 ### Fixed
 
+## [0.77.1]
+### Changed
+* core: Change the PaymentCredentialsFlow's StateFlow to be a SharedFlow w/o replaying and state management
+
 ## [0.77.0]
 ### Added
 * core/ui: Add a feature to pass payment credentials w/o saving it into storage

core/src/main/java/io/snabble/sdk/payment/PaymentCredentialsFlow.kt

@@ -2,13 +2,15 @@
 
 package io.snabble.sdk.payment
 
-import kotlinx.coroutines.flow.MutableStateFlow
+import kotlinx.coroutines.MainScope
+import kotlinx.coroutines.flow.MutableSharedFlow
 import kotlinx.coroutines.flow.SharedFlow
 import kotlinx.coroutines.flow.asSharedFlow
+import kotlinx.coroutines.launch
 
 internal interface MutableCredentialsFlow {
 
-    fun tryEmitCredentials(credentials: PaymentCredentials): Boolean
+    fun emitCredentials(credentials: PaymentCredentials)
 }
 
 /**
@@ -20,13 +22,17 @@ internal interface MutableCredentialsFlow {
  */
 object PaymentCredentialsFlow : MutableCredentialsFlow {
 
-    private val _credentialsFlow = MutableStateFlow<PaymentCredentials?>(null)
+    private val _credentialsFlow = MutableSharedFlow<PaymentCredentials?>()
 
     /**
      * Collect this flow to be notified if payment credentials has been created successfully.
      * If there are no collectors, it will be discarded.
      */
     val credentialsFlow: SharedFlow<PaymentCredentials?> = _credentialsFlow.asSharedFlow()
 
-    override fun tryEmitCredentials(credentials: PaymentCredentials): Boolean = _credentialsFlow.tryEmit(credentials)
+    override fun emitCredentials(credentials: PaymentCredentials) {
+        MainScope().launch {
+            _credentialsFlow.emit(credentials)
+        }
+    }
 }

core/src/main/java/io/snabble/sdk/payment/PaymentCredentialsStore.java

@@ -170,7 +170,7 @@ public synchronized void add(PaymentCredentials credentials) {
     }
 
     public synchronized void justEmitCredentials(final PaymentCredentials credentials) {
-        ((MutableCredentialsFlow) PaymentCredentialsFlow.INSTANCE).tryEmitCredentials(credentials);
+        ((MutableCredentialsFlow) PaymentCredentialsFlow.INSTANCE).emitCredentials(credentials);
     }
 
     /**