Skip to content

Commit a2dc8c4

Browse files
committed
conditional scan message for projects
1 parent e5410ea commit a2dc8c4

File tree

2 files changed

+20
-7
lines changed

2 files changed

+20
-7
lines changed

ui/src/main/java/io/snabble/sdk/ui/scanner/SelfScanningView.java

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -408,14 +408,24 @@ public void onDismiss(DialogInterface dialog) {
408408
}
409409

410410
private void showScanMessage(Product product) {
411+
Project project = SnabbleUI.getProject();
411412
Resources res = getResources();
412413

413414
String identifier = product.getScanMessage();
414415
if (identifier != null) {
415-
identifier = identifier.replace("-", "_");
416-
int id = res.getIdentifier(identifier, "string", getContext().getPackageName());
417-
if (id != 0) {
418-
String str = res.getString(id);
416+
// replace occurences of "-" in scan message, as android resource identifiers are not
417+
// supporting "-" in identifiers
418+
String idWithoutProjectId = identifier.replace("-", ".");
419+
String idWithProjectId = project.getId().replace("-", ".") + "." + idWithoutProjectId;
420+
421+
int resId = res.getIdentifier(idWithProjectId, "string", getContext().getPackageName());
422+
423+
if (resId == 0) {
424+
resId = res.getIdentifier(idWithoutProjectId, "string", getContext().getPackageName());
425+
}
426+
427+
if (resId != 0) {
428+
String str = res.getString(resId);
419429
showInfo(str);
420430
}
421431
}
@@ -516,7 +526,10 @@ public void onItemAdded(ShoppingCart list, ShoppingCart.Item item) {
516526
if (list.getAddCount() == 1) {
517527
showHints();
518528
}
529+
}
519530

531+
@Override
532+
public void onQuantityChanged(ShoppingCart list, ShoppingCart.Item item) {
520533
showScanMessage(item.getProduct());
521534
}
522535

ui/src/main/res/values/strings.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<!-- Android Strings File -->
3-
<!-- Generated by Twine 1.0.2 -->
3+
<!-- Generated by Twine 1.0.4 -->
44
<!-- Language: en -->
55
<resources>
66
<!-- SECTION: Snabble -->
@@ -50,8 +50,8 @@
5050
<string name="Snabble.Scanner.start">Start scanner</string>
5151
<string name="Snabble.Scanner.addCodeAsIs">Add %s as is</string>
5252
<string name="Snabble.ShoppingCart.title">Shopping Cart</string>
53-
<string name="Snabble.Shoppingcart.buyProducts.one">Buy %d product for %s</string>
54-
<string name="Snabble.Shoppingcart.buyProducts">Buy %d products for %s</string>
53+
<string name="Snabble.Shoppingcart.buyProducts.one">Buy %1$d product for %2$s</string>
54+
<string name="Snabble.Shoppingcart.buyProducts">Buy %1$d products for %2$s</string>
5555
<string name="Snabble.Shoppingcart.buyProducts.now">Pay now</string>
5656
<string name="Snabble.Shoppingcart.emptyState.buttonTitle">Scan products</string>
5757
<string name="Snabble.Shoppingcart.emptyState.description">Scan products to add them to your shopping cart.</string>

0 commit comments

Comments
 (0)