Skip to content

Commit 991e3da

Browse files
committed
add null check for key store cipher
1 parent cb122df commit 991e3da

File tree

3 files changed

+21
-14
lines changed

3 files changed

+21
-14
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
# Changelog
22
All notable changes to this project will be documented in this file.
33

4+
## [0.49.1]
5+
6+
### Fixed
7+
- Bypass KeyStoreCipher when it can not be created
8+
49
## [0.49.0]
510

611
### Important Changes

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ allprojects {
3131
}
3232

3333
project.ext {
34-
sdkVersion='0.49.0'
34+
sdkVersion='0.49.1'
3535
versionCode=1
3636

3737
compileSdkVersion=31

core/src/main/java/io/snabble/sdk/payment/PaymentCredentialsStore.java

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -69,20 +69,22 @@ private void initializeKeyStore() {
6969
private void ensureKeyStoreIsAccessible() {
7070
initializeKeyStore();
7171

72-
keyStoreCipher.validate();
73-
74-
String id = keyStoreCipher.id();
75-
if (id == null) {
76-
Logger.errorEvent("Keystore has no id!");
77-
keyStoreCipher = null;
78-
return;
79-
}
72+
if (keyStoreCipher != null) {
73+
keyStoreCipher.validate();
74+
75+
String id = keyStoreCipher.id();
76+
if (id == null) {
77+
Logger.errorEvent("Keystore has no id!");
78+
keyStoreCipher = null;
79+
return;
80+
}
8081

81-
if (!id.equals(data.id)) {
82-
data.id = keyStoreCipher.id();
83-
data.isKeyguarded = true;
84-
Logger.errorEvent("Removing payment credentials, because key store id differs");
85-
removeInvalidCredentials();
82+
if (!id.equals(data.id)) {
83+
data.id = keyStoreCipher.id();
84+
data.isKeyguarded = true;
85+
Logger.errorEvent("Removing payment credentials, because key store id differs");
86+
removeInvalidCredentials();
87+
}
8688
}
8789

8890
Context context = Snabble.getInstance().getApplication();

0 commit comments

Comments
 (0)