removed snackbar in favor of an info dialog

Author: ajungg

ui/src/main/java/io/snabble/sdk/ui/scanner/SelfScanningView.java

@@ -11,14 +11,13 @@
 import android.content.pm.PackageManager;
 import android.os.SystemClock;
 import android.os.Vibrator;
+import android.support.annotation.StringRes;
 import android.support.design.widget.CoordinatorLayout;
-import android.support.design.widget.Snackbar;
 import android.support.v4.app.ActivityCompat;
 import android.support.v7.app.AlertDialog;
 import android.text.InputType;
 import android.util.AttributeSet;
 import android.view.KeyEvent;
-import android.view.LayoutInflater;
 import android.view.View;
 import android.widget.EditText;
 import android.widget.LinearLayout;
@@ -37,7 +36,6 @@
 import io.snabble.sdk.ui.SnabbleUICallback;
 import io.snabble.sdk.ui.telemetry.Telemetry;
 import io.snabble.sdk.ui.utils.DelayedProgressDialog;
-import io.snabble.sdk.ui.utils.OneShotClickListener;
 import io.snabble.sdk.ui.utils.UIUtils;
 import io.snabble.sdk.utils.SimpleActivityLifecycleCallbacks;
 import io.snabble.sdk.utils.Utils;
@@ -160,20 +158,17 @@ public void onShow(DialogInterface dialog) {
     public void lookupAndShowProduct(final ScannableCode scannedCode) {
         productDialog.dismiss();
         ignoreNextDialog = false;
+        pauseBarcodeScanner();
 
         if(scannedCode.hasEmbeddedData() && !scannedCode.isEmbeddedDataOk()){
             delayNextScan();
 
             Telemetry.event(Telemetry.Event.ScannedUnknownCode, scannedCode.getCode());
-            UIUtils.snackbar(SelfScanningView.this,
-                    R.string.Snabble_Scanner_unknownBarcode,
-                    UIUtils.SNACKBAR_LENGTH_VERY_LONG)
-                    .show();
+            showInfo(R.string.Snabble_Scanner_unknownBarcode);
             return;
         }
 
         progressDialog.showAfterDelay(300);
-        pauseBarcodeScanner();
 
         if(scannedCode.hasEmbeddedData()){
             productDatabase.findByWeighItemIdOnline(scannedCode.getLookupCode(), new OnProductAvailableListener() {
@@ -240,13 +235,10 @@ private void handleProductAvailable(Product product, boolean wasOnlineProduct, S
             showBundleDialog(product);
         } else {
             if (product.getType() == Product.Type.PreWeighed && !scannedCode.hasEmbeddedData()) {
-                UIUtils.snackbar(SelfScanningView.this,
-                        R.string.Snabble_Scanner_scannedShelfCode,
-                        UIUtils.SNACKBAR_LENGTH_VERY_LONG)
-                        .show();
+
+                showInfo(R.string.Snabble_Scanner_scannedShelfCode);
 
                 progressDialog.dismiss();
-                resumeBarcodeScanner();
                 delayNextScan();
             } else {
                 showProduct(product, scannedCode);
@@ -262,25 +254,27 @@ private void handleProductAvailable(Product product, boolean wasOnlineProduct, S
 
     private void handleProductNotFound(ScannableCode scannedCode) {
         progressDialog.dismiss();
-        resumeBarcodeScanner();
         delayNextScan();
 
         Telemetry.event(Telemetry.Event.ScannedUnknownCode, scannedCode.getCode());
-        UIUtils.snackbar(SelfScanningView.this,
-                R.string.Snabble_Scanner_unknownBarcode,
-                UIUtils.SNACKBAR_LENGTH_VERY_LONG)
-                .show();
+
+        showInfo(R.string.Snabble_Scanner_unknownBarcode);
     }
 
     private void handleProductError() {
         progressDialog.dismiss();
-        resumeBarcodeScanner();
         delayNextScan();
 
-        UIUtils.snackbar(SelfScanningView.this,
-                R.string.Snabble_Scanner_networkError,
-                UIUtils.SNACKBAR_LENGTH_VERY_LONG)
-                .show();
+        showInfo(R.string.Snabble_Scanner_networkError);
+    }
+
+    private void showInfo(@StringRes int resId) {
+        UIUtils.info(getContext(), resId, new DialogInterface.OnDismissListener() {
+            @Override
+            public void onDismiss(DialogInterface dialog) {
+                resumeBarcodeScanner();
+            }
+        });
     }
 
     private void onClickEnterBarcode() {

ui/src/main/java/io/snabble/sdk/ui/utils/UIUtils.java

@@ -3,19 +3,32 @@
 import android.app.Activity;
 import android.content.Context;
 import android.content.ContextWrapper;
+import android.content.DialogInterface;
 import android.graphics.Color;
 import android.os.Build;
 import android.support.annotation.StringRes;
 import android.support.design.widget.Snackbar;
+import android.support.v7.app.AlertDialog;
 import android.text.Spannable;
 import android.text.SpannableString;
 import android.text.style.ForegroundColorSpan;
 import android.view.View;
 import android.widget.TextView;
 
+import io.snabble.sdk.ui.R;
+
 public class UIUtils {
     public static final int SNACKBAR_LENGTH_VERY_LONG = 5000;
 
+    public static void info(Context context, @StringRes int stringResId, DialogInterface.OnDismissListener onDismissListener) {
+        new AlertDialog.Builder(context)
+                .setMessage(stringResId)
+                .setPositiveButton(R.string.Snabble_OK, null)
+                .setOnDismissListener(onDismissListener)
+                .create()
+                .show();
+    }
+
     public static Snackbar snackbar(View view, @StringRes int stringResId, int duration) {
         Snackbar snackbar = Snackbar.make(view, stringResId, duration);
         fixTextColor(snackbar);