fix telemetry & configurable cart timeout

Author: ajungg

CHANGELOG.md

@@ -3,12 +3,18 @@ All notable changes to this project will be documented in this file.
 
 ## [0.13.14]
 
+### Added
+- Added Config parameter maxShoppingCartAge
+
+### Removed
+- Removed config parameter enableReceiptAutoDownload as it is no longer used
 
 ### Changes
 - Add keepScreenOn flag on checkout view
 
 ### Fixed
 - Null pointer in very rare circumstances using ZXing Barcode Detector 
+- CheckoutSuccessful Telemetry Event was not firing
 
 ## [0.13.13]
 

core/src/main/java/io/snabble/sdk/ShoppingCart.java

@@ -20,7 +20,6 @@
 
 public class ShoppingCart {
     public static final int MAX_QUANTITY = 99999;
-    public static final long TIMEOUT = TimeUnit.HOURS.toMillis(4);
 
     private String id;
     private long lastModificationTime;
@@ -224,7 +223,8 @@ public void updatePrices(boolean debounce) {
     public void checkForTimeout() {
         long currentTime = System.currentTimeMillis();
 
-        if (lastModificationTime + TIMEOUT < currentTime) {
+        long timeout = Snabble.getInstance().getConfig().maxShoppingCartAge;
+        if (lastModificationTime + timeout < currentTime) {
             invalidate();
         }
     }

core/src/main/java/io/snabble/sdk/Snabble.java

@@ -532,10 +532,13 @@ public static class Config {
         public long maxProductDatabaseAge = TimeUnit.HOURS.toMillis(1);
 
         /**
-         * If set to true, downloads receipts automatically and stores them in the projects
-         * internal storage folder.
+         * The time that the shopping cart is allowed to be alive after the last modification.
+         *
+         * The time is specified in milliseconds.
+         *
+         * The default value is 4 hours.
          */
-        public boolean enableReceiptAutoDownload;
+        public long maxShoppingCartAge = TimeUnit.HOURS.toMillis(4);
 
         /** If set to true, disables certificate pinning **/
         public boolean disableCertificatePinning;

ui/src/main/java/io/snabble/sdk/ui/checkout/CheckoutView.java

@@ -19,6 +19,7 @@
 import io.snabble.sdk.encodedcodes.EncodedCodesOptions;
 import io.snabble.sdk.ui.R;
 import io.snabble.sdk.ui.SnabbleUI;
+import io.snabble.sdk.ui.telemetry.Telemetry;
 import io.snabble.sdk.ui.utils.DelayedProgressDialog;
 import io.snabble.sdk.ui.utils.UIUtils;
 import io.snabble.sdk.utils.SimpleActivityLifecycleCallbacks;
@@ -91,6 +92,7 @@ public void onStateChanged(Checkout.State state) {
             case PAYMENT_APPROVED:
                 if (!checkout.getSelectedPaymentMethod().isOfflineMethod()) {
                     displayView(new CheckoutDoneView(getContext()));
+                    Telemetry.event(Telemetry.Event.CheckoutSuccessful);
                 }
                 break;
             case PAYMENT_ABORTED: