Skip to content

Commit 60778d6

Browse files
committed
Remove extension marginTop/Bottom use margin.top/bottom instead
1 parent 18102ef commit 60778d6

File tree

2 files changed

+11
-22
lines changed

2 files changed

+11
-22
lines changed

CHANGELOG.md

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,19 +5,20 @@ All notable changes to this project will be documented in this file.
55

66
### Added
77
- Added support for displaying coupons
8-
- Added CouponFragment to display a single coupon
9-
- Added CouponDetailActivity to display a single coupon in an Activity
10-
- Added CouponOverviewView to display a collection of coupons depending on the project
8+
- Added `CouponFragment` to display a single coupon
9+
- Added `CouponDetailActivity` to display a single coupon in an `Activity`
10+
- Added `CouponOverviewView` to display a collection of coupons depending on the project
1111

1212
### Changed
1313
- Added lots of Javadoc documentation to core classes
14-
- Converted to OkHttpClientFactory to kotlin
15-
- Converted to MetadataDownloader to kotlin
16-
- Converted to FulfillmentState to kotlin
17-
- Converted to OnProductAvailableListener to kotlin
18-
- Converted to PaymentMethod to kotlin
19-
- Converted to PaymentOriginCandiadateHelper to kotlin
20-
- Converted to ScannedCode to kotlin
14+
- Converted to `OkHttpClientFactory` to Kotlin
15+
- Converted to `MetadataDownloader` to Kotlin
16+
- Converted to `FulfillmentState` to Kotlin
17+
- Converted to `OnProductAvailableListener` to Kotlin
18+
- Converted to `PaymentMethod` to Kotlin
19+
- Converted to `PaymentOriginCandidateHelper` to Kotlin
20+
- Converted to `ScannedCode` to Kotlin
21+
- Replaced view extension properties `marginTop`/`Bottom` with `margin.top`/`bottom`
2122

2223
## [0.64.1]
2324

ui/src/main/java/io/snabble/sdk/ui/utils/ViewExt.kt

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -59,18 +59,6 @@ fun View.setOneShotClickListener(callback: () -> Unit) =
5959
}
6060
)
6161

62-
inline var View.marginTop: Int
63-
get() = (layoutParams as? ViewGroup.MarginLayoutParams)?.topMargin ?: 0
64-
set(value) {
65-
(layoutParams as? ViewGroup.MarginLayoutParams)?.topMargin = value
66-
}
67-
68-
inline var View.marginBottom: Int
69-
get() = (layoutParams as? ViewGroup.MarginLayoutParams)?.bottomMargin ?: 0
70-
set(value) {
71-
(layoutParams as? ViewGroup.MarginLayoutParams)?.bottomMargin = value
72-
}
73-
7462
inline val View.idName: String
7563
get() = if (id == -1) "null" else context.resources.getResourceName(id)
7664

0 commit comments

Comments
 (0)