Skip to content

Commit 2561e01

Browse files
authored
Allow artifacts of the same name to be overwritten (#3509)
## Motivation and Context ## Description After [upgrading to actions/upload-artifact@v4](#3497), it seems to have brought a behavior change where an artifact with the same name is [disallowed by default](https://github.com/smithy-lang/smithy-rs/actions/runs/8423689643/job/23067178393#step:4:639) within a workflow run. This happened during a [release](https://github.com/smithy-lang/smithy-rs/blob/main/.github/workflows/release.yml) workflow where it first invoked ci.yml (which then called `generate-smithy-rs-release` and created an artifact with that action name) and then called `generate-smithy-rs-release` by itself (attempted to create an artifact with that action name again, leading to the error above). This was not a problem previously when we were using `actions/upload-artifact@v3`. This PR explicitly sets `overwrite: true` to bring back the old behavior for a place that's affected. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
1 parent 2d931fa commit 2561e01

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

.github/actions/docker-build/action.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,3 +66,4 @@ runs:
6666
path: artifacts-${{ inputs.action }}.tar.gz
6767
if-no-files-found: error
6868
retention-days: 3
69+
overwrite: true

0 commit comments

Comments
 (0)