Skip to content

Commit 119c87c

Browse files
authored
Rework addressing code review feedback in smithy-rs#3859 (#3860)
## Motivation and Context 1dbf37a didn't address [code review feedback](#3859 (comment)) correctly. This PR will fix it. ## Testing Tests in CI ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
1 parent e7f1031 commit 119c87c

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

aws/sdk/integration-tests/ec2/tests/paginators.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,11 @@ fn stub_config(http_client: impl HttpClient + 'static) -> Config {
1818
.build()
1919
}
2020

21-
fn validate_query_string(expected: &str, actual: &str) {
22-
let expected = expected.split('&').collect::<HashSet<&str>>();
23-
let actual = actual.split('&').collect::<HashSet<&str>>();
21+
fn validate_query_string(expected_str: &str, actual_str: &str) {
22+
assert_eq!(expected_str.len(), actual_str.len());
23+
let expected = expected_str.split('&').collect::<HashSet<_>>();
24+
let actual = actual_str.split('&').collect::<HashSet<_>>();
2425
assert_eq!(expected, actual);
25-
assert_eq!(expected.len(), actual.len());
2626
}
2727

2828
/// See https://github.com/awslabs/aws-sdk-rust/issues/391

0 commit comments

Comments
 (0)