Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.5.0 introduces BREAKING CHANGES #184

Open
Wirone opened this issue Dec 21, 2022 · 4 comments
Open

Release 1.5.0 introduces BREAKING CHANGES #184

Wirone opened this issue Dec 21, 2022 · 4 comments

Comments

@Wirone
Copy link

Wirone commented Dec 21, 2022

Version 1.5.0 released yesterday introduced breaking changes and should be released as 2.0.0 ⚠️

For example:

Argument 1 passed to ClickHouseDB\Settings::setReadOnlyUser() must be an instance of ClickHouseDB\mixed, bool given, called in /app/vendor/smi2/phpclickhouse/src/Client.php on line 139

This release contains types introduced in PHP8 while composer.json defines requirement "php": "^7.3|^8.0" and allows installation on PHP7.4 (which we're using).

Please consider cleaning this up 🙂

@isublimity
Copy link
Contributor

isublimity commented Dec 21, 2022

Thx for you report!
I re-upload 1.5.0 with hot fix

@Wirone
Copy link
Author

Wirone commented Dec 21, 2022

I believe it wouldn't happen if there was any CI setup. As far as I see there is no Github Actions definition and Travis was run last time 2 years ago. PHPStan's version is prehistoric (current: 1.9.4) and it reports problems even on level 1 (configured in phpstan.neon.dist):

image

When running it on level 7 (like in the readme), it returns 366 errors... You really need apply some hygiene here, because it really looks unstable 🙁

@Wirone
Copy link
Author

Wirone commented Jan 9, 2023

@isublimity friendly reminder, because I see updated tag wasn't released.

@Wirone
Copy link
Author

Wirone commented Apr 20, 2023

@isublimity it's been 4 months now... Please, fix this or just let us know you won't do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants