Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc_server::stop doesnot stop its service #366

Open
laomd opened this issue Nov 21, 2019 · 2 comments
Open

rpc_server::stop doesnot stop its service #366

laomd opened this issue Nov 21, 2019 · 2 comments

Comments

@laomd
Copy link

laomd commented Nov 21, 2019

Describe the bug
routes_.stop() is not called in rpc_server::stop()

@emaxerrno
Copy link
Collaborator

oh good point. @laomd please see our CONTRIBUTING.md and submit a quick patch. should be fairly easy.

@emaxerrno
Copy link
Collaborator

hi @laomd i saw you sent a patch on the mailing list yesterday, I'll get to it this weekend/tom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants