Simplify timestamp parsing - Date() handles both formats

mohamed-mehany · mohamed-mehany · commit 3cd6086098bc · 2026-02-03T19:44:29.000+04:00
diff --git a/packages/sources/generic-api/src/transport/multi-http.ts b/packages/sources/generic-api/src/transport/multi-http.ts
@@ -72,13 +72,7 @@ const transportConfig: HttpTransportConfig<HttpTransportTypes> = {
           }
         }
         const timestampValue = objectPath.get(response.data, param.providerIndicatedTimePath)
-
-        // Support both ISO 8601 strings and Unix milliseconds (number)
-        if (typeof timestampValue === 'number') {
-          providerIndicatedTimeUnixMs = timestampValue
-        } else {
-          providerIndicatedTimeUnixMs = new Date(timestampValue).getTime()
-        }
+        providerIndicatedTimeUnixMs = new Date(timestampValue).getTime()
 
         // Validate: must be finite and positive
         if (!Number.isFinite(providerIndicatedTimeUnixMs) || providerIndicatedTimeUnixMs <= 0) {

Original file line number	Diff line number	Diff line change
`@@ -72,13 +72,7 @@ const transportConfig: HttpTransportConfig<HttpTransportTypes> = {`
`72`	`72`	`}`
`73`	`73`	`}`
`74`	`74`	`const timestampValue = objectPath.get(response.data, param.providerIndicatedTimePath)`
`75`		`-`
`76`		`- // Support both ISO 8601 strings and Unix milliseconds (number)`
`77`		`- if (typeof timestampValue === 'number') {`
`78`		`- providerIndicatedTimeUnixMs = timestampValue`
`79`		`- } else {`
`80`		`- providerIndicatedTimeUnixMs = new Date(timestampValue).getTime()`
`81`		`- }`
	`75`	`+ providerIndicatedTimeUnixMs = new Date(timestampValue).getTime()`
`82`	`76`
`83`	`77`	`// Validate: must be finite and positive`
`84`	`78`	`if (!Number.isFinite(providerIndicatedTimeUnixMs) \|\| providerIndicatedTimeUnixMs <= 0) {`