-
Notifications
You must be signed in to change notification settings - Fork 1
DS-1732 channel definition opts cache #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
akuzni2
wants to merge
12
commits into
master
Choose a base branch
from
DS-1732-channel-opts-cache
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
channelDefinitionOptsCache add locking to operations to protect cache validity
channelDefinitionOptsCache add locking to operations to protect cache validity
brunotm
requested changes
Dec 5, 2025
brunotm
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add ChannelDefinitionOptsCache to optimize access to ReportCodec options especially in outcome and reporting.
Current usage of ChannelDefinition Opts requires parsing Opts from JSON Bytes -> struct which has an impact on performance with many channels.
See the added bechmark test for performance gain of switching to cache approach.
Cache Design and Usage
The design of the cache needed to work with varying types of Opts as each ReportCodec manages it's own Opts struct. Therefore what the cache stores is a generic type
anywhich is faster to type assert than it is to re-parse from JSON bytes.Where we need to access Opts - we can expose a new
OptsProviderand each codec that we'd like information from can Implement it such asTimeResolutionProviderorABIProviderorSomeOtherUniqueOptProvider. Not all codecs need implement these interfaces which is good interface segregation.Interface Change
Noting that interface was changed
ReportCodec.Encode()This was chosen as it's easier at the call site when encoding with various possibilities of ReportCodecs to use the pattern of:
Encode(report, opts)