Implement TON hasher #69
Draft
+1,807
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report |
andrevmatos
reviewed
Dec 8, 2025
Collaborator
andrevmatos
left a comment
andrevmatos
left a comment
There was a problem hiding this comment.
Nice! Some heads-up and nits, but overall, looking great for the new pattern! Ty!
| | (EVMExtraArgsV2 & { _tag: 'EVMExtraArgsV2' }) | ||
| | (SVMExtraArgsV1 & { _tag: 'SVMExtraArgsV1' }) | ||
| | (SuiExtraArgsV1 & { _tag: 'SuiExtraArgsV1' }) | ||
| | (GenericExtraArgsV2 & { _tag: 'GenericExtraArgsV2' }) |
Collaborator
There was a problem hiding this comment.
We should still name this EVMExtraArgsV2; the _tag alias isn't of much use since this is actually the same type; trying to union it even makes TS complain (as above)
| readonly network: NetworkInfo<typeof ChainFamily.TON> | ||
|
|
||
| constructor(network: NetworkInfo<typeof ChainFamily.TON>) { | ||
| super() |
Collaborator
There was a problem hiding this comment.
Just a heads-up: #70 changes slightly constructor/super call, passing network to super, plus some context/logger objects; should be trivial to adapt
Comment on lines
+127
to
+129
| async getWalletAddress(_opts?: { wallet?: unknown }): Promise<string> { | ||
| return Promise.reject(new Error('Not implemented')) | ||
| } |
Collaborator
There was a problem hiding this comment.
This one is going away as well
| * @param args - Extra arguments containing gas limit and execution flags | ||
| * @returns Hex string of BOC-encoded extra args (0x-prefixed) | ||
| */ | ||
| static encodeExtraArgs(args: ExtraArgs): string { |
Collaborator
There was a problem hiding this comment.
Just FYI, encode/decodeExtraArgs are from the perspective of this source chain, to other chains; if TON is expected to send only to EVM at first, then it's fine to implement only EVMExtraArgsV2 encoding here; but if it's expected soon to support lanes to Solana, etc, you may also want to have serializations (with TON's codecs) of extraArgs to those chains
| return Promise.reject(new Error('Not implemented')) | ||
| } | ||
|
|
||
| async sendMessage( |
Collaborator
There was a problem hiding this comment.
Heads-up: #70 also include some new methods, generateUnsigned*; again, should be trivial to add the Not implemented versions just to satisfy the interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.