-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packaging mode for studies #323
Conversation
prepare: bool = False, | ||
data_path: pathlib.Path | None = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: here and in build_matching_files
, I might drop any default argument. Because you pass in prepare
and data_path
everywhere you call these, and you want to avoid a future bug where a new call to these gets introduced but the dev forgets to pass down the CLI arg.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm leaving this in at the main entrypoint since a lot of tests assume it's there, but i've pulled everything downstream
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
-Adds a new cli param to the build argument,
--prepare
, which renders queries instead of execute them-Adds a fixture to replace individual instances of clearing os environment variables
Checklist
docs/
needs to be updatedgenerate-md
core
study fields that not in US Core, update our list of those incore-study-details.md
manifest.toml