Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DocumentReference attachment/url check #7

Closed
gotdan opened this issue Apr 11, 2024 · 3 comments · Fixed by #64
Closed

DocumentReference attachment/url check #7

gotdan opened this issue Apr 11, 2024 · 3 comments · Fixed by #64
Labels
enhancement New feature or request

Comments

@gotdan
Copy link

gotdan commented Apr 11, 2024

Currently, the us-core-6 attachment data/url check for DocumentReference is skipped since Cumulus strips that element. This makes sense once the data has been loaded, but it's an important check if we plan to process the notes coming from bulk data using NLP. Should we have a flag to enable this, or alternatively, add a "NLP ready" version of the metric that inherits from the US Core metric and adds this check?

@gotdan gotdan changed the title DocumentReference attachment/url DocumentReference attachment/url check Apr 11, 2024
@mikix
Copy link
Contributor

mikix commented Apr 11, 2024

We talked about this off-github and we agree there's probably utility in a docref attachment metric talking about content types and all that jazz - but it would need to run in a mode that operated on the original ndjson, not the post-ETL ndjson

@mikix mikix added the enhancement New feature or request label Apr 12, 2024
@mikix
Copy link
Contributor

mikix commented May 10, 2024

Also see #23

@mikix
Copy link
Contributor

mikix commented Nov 7, 2024

One piece of this puzzle that would allow analyzing url/data fields en masse (not just local data mode) is smart-on-fhir/cumulus-etl#361

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants