Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ED Note definition lives in core, not covid symptom (core__ed_note) #10

Open
comorbidity opened this issue Jun 15, 2023 · 0 comments
Open
Assignees

Comments

@comorbidity
Copy link
Contributor

for historical reasons, the ED Note definition truly lives in CORE and not in COVID symptom.
Note that ED NOTE is also referenced by suicidality study, but for suicidality the study criteria changed to also include Psych visits, not just ED visits.

Conclusion: move ED NOTE dependance out of library CORE and into each study (covid and suicide) so that each study can change independently.

CURRENTLY IS IGNORED
CREATE OR REPLACE VIEW covid_symptom__site_ed_note AS
https://github.com/smart-on-fhir/cumulus-library-covid/blob/main/cumulus_library_covid/covid_symptom/site_define.sql#L102

BECAUSE

https://github.com/smart-on-fhir/cumulus-library-covid/blob/main/cumulus_library_covid/covid_symptom/count_covid_prevalence_ed.sql
depends on

https://github.com/smart-on-fhir/cumulus-library-covid/blob/main/cumulus_library_covid/covid_symptom/count_covid_study_period.sql
depends on

https://github.com/smart-on-fhir/cumulus-library-core/blob/main/cumulus_library/studies/core/study_period.sql
depends on

https://github.com/smart-on-fhir/cumulus-library-core/blob/main/cumulus_library/studies/core/setup.sql

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants