-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Study period detection #68
Conversation
STUDY_PERIOD_METADATA_TEMPLATE = { | ||
"version": "1.0", | ||
"earliest_date": None, | ||
"latest_date": None, | ||
"last_data_update": None, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
explaining the business semantics here: a study period encapsulates all exports associated with a study, so there's only one date range element per study topic. This gets us around 'not every count table will have a date column in it'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got some classic Mike nitpicks but looks good!
tests/test_data/meta_date.parquet
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Binaries. setUp
method to the binary version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so, this is a copy/paste of the library output, which is what we're expectinging and I think the best test case for "will this actually work". but - i can add a copy of the csv output for the same and use that during the validation step, which will also help to self document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, added and used for validation.
This PR makes the following changes: