Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinkedIn Authentication #278

Open
himanshusharma89 opened this issue Oct 1, 2020 · 20 comments
Open

LinkedIn Authentication #278

himanshusharma89 opened this issue Oct 1, 2020 · 20 comments
Assignees

Comments

@himanshusharma89
Copy link
Collaborator

No description provided.

@SirusCodes
Copy link
Contributor

I can do this by this package

@himanshusharma89
Copy link
Collaborator Author

Okay, @SirusCodes go ahead. Assigning it to you.

@SirusCodes
Copy link
Contributor

Yup Thanks👍

@SirusCodes
Copy link
Contributor

SirusCodes commented Oct 2, 2020

@himanshusharma89 can you give me client id and client secret?
You can send me a mail or message me any social media

@himanshusharma89
Copy link
Collaborator Author

@SirusCodes you can create an example app yourself and try it, I'll change it after merging it

@SirusCodes
Copy link
Contributor

SirusCodes commented Oct 3, 2020

Can you give me your android debug key or will you add mine to the project?
I also need to use custom token as firebase doesn't support LinkedIn login natively
Also please do the required in firebase as in the link above

@himanshusharma89
Copy link
Collaborator Author

@SirusCodes share me your gmail, I'll add you to the project in the console.

@SirusCodes
Copy link
Contributor

[email protected]

@himanshusharma89
Copy link
Collaborator Author

@SirusCodes I have added you to the console, you can work on it now.

@SirusCodes
Copy link
Contributor

I got the notification I would start working on it soon...

@SirusCodes
Copy link
Contributor

Hey @himanshusharma89 I made changes in the application, but linkedin have a review process to allow sign in with linkedin. I don't think that my request would be accepted. So should I make a PR now or something else?

@himanshusharma89
Copy link
Collaborator Author

@SirusCodes Create a PR from a different branch, I'll label it to be eligible for Hacktoberfest

@SirusCodes
Copy link
Contributor

SirusCodes commented Oct 3, 2020

@himanshusharma89 why #285 is not counted as eligible PR for hacktoberfest?

@himanshusharma89
Copy link
Collaborator Author

@SirusCodes Hacktoberfst added new rules against spamming, I'll add a label and it'll be counted. Check this: https://hacktoberfest.digitalocean.com/hacktoberfest-update

@himanshusharma89
Copy link
Collaborator Author

@SirusCodes Check it now

@SirusCodes
Copy link
Contributor

SirusCodes commented Oct 3, 2020

@himanshusharma89 Not yet...maybe it will take some time I guess...thanks😃

@umang-sinha
Copy link

Is this still active? I would like to work on this

@himanshusharma89
Copy link
Collaborator Author

Sure @umang-sinha, assigning it to you.

@himanshusharma89
Copy link
Collaborator Author

I am sure @SirusCodes has eyes on some other projects 😆

@SirusCodes
Copy link
Contributor

SirusCodes commented Oct 4, 2021

@himanshusharma89 The issue should be closed by now as the code was complete, @umang-sinha maybe can fix deprecated APIs if any😅

@umang-sinha I would suggest you to continue with this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants