Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project does not build with DISCORDRPC=1 #559

Open
krnlexception opened this issue May 18, 2024 · 5 comments
Open

Project does not build with DISCORDRPC=1 #559

krnlexception opened this issue May 18, 2024 · 5 comments

Comments

@krnlexception
Copy link

krnlexception commented May 18, 2024

Describe the bug
Project doesn't compile on Linux

To Reproduce
Steps to reproduce the behavior:

  1. make BETTERCAMERA=1 EXTERNAL_DATA=1 EXT_OPTIONS_MENU=1 TEXTSAVES=1 -j6
  2. Building will fail with error if DISCORDRPC is set to 1
/usr/bin/ld: build/us_pc/src/pc/discord/discordrpc.o: in function `discord_update_rich_presence':
discordrpc.c:(.text+0x322): undefined reference to `configDiscordRPC'
/usr/bin/ld: build/us_pc/src/pc/discord/discordrpc.o: in function `discord_init':
discordrpc.c:(.text+0x427): undefined reference to `configDiscordRPC'

or

/usr/bin/ld: build/us_pc/src/pc/pc_main.o: in function `game_deinit':
pc_main.c:(.text+0x445): undefined reference to `discord_shutdown'
/usr/bin/ld: build/us_pc/src/pc/pc_main.o: in function `main_func':
pc_main.c:(.text+0x5ed): undefined reference to `discord_init'
/usr/bin/ld: pc_main.c:(.text+0x61e): undefined reference to `discord_update_rich_presence'

if not

Expected behavior
Project should build

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Arch Linux
  • Version: rolling

Additional context
Add any other context about the problem here.

@krnlexception
Copy link
Author

Updated description because it does not compile at all, but it's the same failure as with DISCORDRPC=1

@fgsfdsfgs
Copy link
Collaborator

Did you make clean before building with different build options?

@krnlexception
Copy link
Author

Did you make clean before building with different build options?

It did not work for me before but works now. Still, there's an issue with building with Discord RPC enabled

@fgsfdsfgs
Copy link
Collaborator

I cannot reproduce this. You should clean build with all the options at once. If you change the options without cleaning first, build will fail because some objects from the previous build will be stuck in the build folder.

@krnlexception
Copy link
Author

I cannot reproduce this. You should clean build with all the options at once. If you change the options without cleaning first, build will fail because some objects from the previous build will be stuck in the build folder.

I tried, I also tried deleting local copy and cloning repository again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants