Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constellation lines are not drawn if some stars are not visible #70

Open
danielortiz opened this issue Feb 5, 2020 · 2 comments
Open

Comments

@danielortiz
Copy link

I noticed that the constellation lines are only drawn when both points (stars) are being rendered.

with the whole constellation visible
image

with part of the constellation out of sight
image

I wonder if that's intentional. If not, how would you go about fixing it? I'd be down to try to push a PR to fix but I could use some guidance on how since I don't understand much of the astronomy side of it

@slowe
Copy link
Owner

slowe commented Mar 10, 2020

The code draws simple lines between the two stars and so it avoids drawing lines when one of the stars is outside the view. In the projection you are using there, the stars that aren't rendered are behind you. If you just "join the dots" you can get distorted/misleading lines in some cases so the lesser "bad" situation was to not draw them.

@slowe
Copy link
Owner

slowe commented Mar 10, 2020

If you were doing better/fuller 3D rendering and drawing lines around a sphere (rather than joining two points on a sphere) this wouldn't be an issue. That would need complete re-design of the rendering or the addition of a "heavy" library that can do full 3D stuff better. I'm trying to keep the size of this project down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants