Skip to content

Commit 0047c7c

Browse files
committed
Cupertino button colors for Primary and secondary buttons assigned correctly
1 parent 0a1d8e0 commit 0047c7c

File tree

2 files changed

+21
-29
lines changed

2 files changed

+21
-29
lines changed

internal/compiler/widgets/cupertino/button.slint

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -31,19 +31,20 @@ export component Button {
3131
accessible-checkable: root.checkable;
3232
accessible-checked: root.checked;
3333
accessible-label: root.text;
34-
accessible-action-default => { i-touch-area.clicked(); }
35-
34+
accessible-action-default => {
35+
i-touch-area.clicked();
36+
}
3637

3738
states [
38-
disabled when !i-touch-area.enabled : {
39+
disabled when !i-touch-area.enabled: {
3940
root.text-color: CupertinoPalette.foreground-secondary;
4041
root.background: CupertinoPalette.quaternary-control-background;
4142
}
42-
pressed when root.pressed : {
43+
pressed when root.pressed: {
4344
root.background: root.primary ? CupertinoPalette.secondary-accent-background : CupertinoPalette.secondary-control-background;
4445
}
45-
checked when root.checked : {
46-
root.text-color: CupertinoPalette.secondary-accent-background;
46+
checked when root.checked: {
47+
root.text-color: CupertinoPalette.accent-foreground;
4748
}
4849
]
4950

@@ -58,7 +59,7 @@ export component Button {
5859
has-focus: root.has-focus;
5960
}
6061

61-
if (root.primary && root.enabled) : Rectangle {
62+
if (root.primary && root.enabled): Rectangle {
6263
drop-shadow-blur: 3px;
6364
drop-shadow-color: #00000066;
6465
drop-shadow-offset-y: 0.5px;
@@ -88,7 +89,7 @@ export component Button {
8889
}
8990
}
9091

91-
if (!root.primary || !root.enabled) : Rectangle {
92+
if (!root.primary || !root.enabled): Rectangle {
9293
drop-shadow-blur: 0.25px;
9394
drop-shadow-color: #00000066;
9495
drop-shadow-offset-y: 0.25px;
@@ -115,15 +116,15 @@ export component Button {
115116
spacing: 4px;
116117
alignment: center;
117118

118-
if (root.icon.width > 0 && root.icon.height > 0) : Image {
119+
if (root.icon.width > 0 && root.icon.height > 0): Image {
119120
y: (parent.height - self.height) / 2;
120121
source <=> root.icon;
121122
width: 13px;
122123
opacity: root.enabled ? 1 : 0.5;
123124
colorize: root.colorize-icon ? root.text-color : transparent;
124125
}
125126

126-
if (root.text != "") : Text {
127+
if (root.text != ""): Text {
127128
opacity: root.enabled ? 1 : 0.5;
128129
font-size: CupertinoFontSettings.body.font-size;
129130
font-weight: CupertinoFontSettings.body.font-weight;
@@ -153,9 +154,8 @@ export component Button {
153154
key-pressed(event) => {
154155
if (event.text == " " || event.text == "\n") {
155156
i-touch-area.clicked();
156-
return accept;
157+
return accept;
157158
}
158-
159159
return reject;
160160
}
161161
}

internal/compiler/widgets/cupertino/styling.slint

Lines changed: 9 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -13,23 +13,14 @@ export global CupertinoFontSettings {
1313
out property <int> regular-font-weight: 400;
1414
out property <int> semibold-font-weight: 600;
1515

16-
out property <TextStyle> body: {
17-
font-size: 13 * 0.0769rem,
18-
font-weight: regular-font-weight
19-
};
16+
out property <TextStyle> body: { font-size: 13 * 0.0769rem, font-weight: regular-font-weight };
2017

21-
22-
out property <TextStyle> title: {
23-
font-size: 28 * 0.0769rem,
24-
font-weight: light-font-weight
25-
};
18+
out property <TextStyle> title: { font-size: 28 * 0.0769rem, font-weight: light-font-weight };
2619

2720
// needed?
28-
out property <TextStyle> body-strong: {
29-
font-size: 14 * 0.0769rem,
30-
font-weight: semibold-font-weight
31-
};
21+
out property <TextStyle> body-strong: { font-size: 14 * 0.0769rem, font-weight: semibold-font-weight };
3222
}
23+
3324
export global CupertinoColors {
3425
out property <color> systemGray: #8E8E93;
3526
out property <color> systemGray2: #AEAEB2;
@@ -63,6 +54,7 @@ export global CupertinoColors {
6354

6455
out property <brush> selection-color: self.blue;
6556
}
57+
6658
export global CupertinoPalette {
6759
in-out property <ColorScheme> color-scheme: ColorSchemeSelector.color-scheme;
6860
property <bool> dark-color-scheme: {
@@ -73,11 +65,11 @@ export global CupertinoPalette {
7365
}
7466

7567
// base palette
76-
out property <brush> background: dark-color-scheme ? CupertinoColors.systemGray55-dark: CupertinoColors.systemGray55;
68+
out property <brush> background: dark-color-scheme ? CupertinoColors.systemGray55-dark : CupertinoColors.systemGray55;
7769
out property <brush> foreground: dark-color-scheme ? CupertinoColors.systemGray6 : CupertinoColors.systemGray6-dark;
7870
out property <brush> alternate-background: dark-color-scheme ? CupertinoColors.systemGray5-dark : CupertinoColors.systemGray5;
7971
out property <brush> alternate-foreground: dark-color-scheme ? CupertinoColors.systemGray5 : CupertinoColors.systemGray5-dark;
80-
out property <brush> control-background: dark-color-scheme ? CupertinoColors.systemGray2-dark : CupertinoColors.systemGray6;
72+
out property <brush> control-background: dark-color-scheme ? CupertinoColors.systemGray2-dark : CupertinoColors.white;
8173
out property <brush> control-foreground: dark-color-scheme ? CupertinoColors.systemGray4 : CupertinoColors.systemGray5-dark;
8274
out property <brush> accent-background: dark-color-scheme ? CupertinoColors.selection-color : CupertinoColors.selection-color;
8375
out property <brush> accent-foreground: CupertinoColors.systemGray5;
@@ -92,7 +84,7 @@ export global CupertinoPalette {
9284
out property <brush> tertiary-accent-background: dark-color-scheme ? CupertinoColors.blue : CupertinoColors.blue;
9385
out property <brush> foreground-neg: dark-color-scheme ? CupertinoColors.systemGray6-dark : CupertinoColors.systemGray6;
9486
out property <brush> foreground-secondary: dark-color-scheme ? CupertinoColors.systemGray6.transparentize(0.4) : CupertinoColors.systemGray6-dark.transparentize(0.4);
95-
out property <brush> secondary-control-background: dark-color-scheme ? CupertinoColors.systemGray : CupertinoColors.systemGray;
87+
out property <brush> secondary-control-background: dark-color-scheme ? CupertinoColors.systemGray : CupertinoColors.systemGray55;
9688
out property <brush> tertiary-control-background: dark-color-scheme ? CupertinoColors.systemGray5-dark : CupertinoColors.systemGray5;
9789
out property <brush> quaternary-control-background: dark-color-scheme ? CupertinoColors.systemGray2-dark : CupertinoColors.systemGray6;
9890
out property <brush> alternate-control-background: dark-color-scheme ? CupertinoColors.systemGray3-dark : CupertinoColors.systemGray3;
@@ -104,7 +96,7 @@ export global CupertinoPalette {
10496
out property <brush> separator: dark-color-scheme ? CupertinoColors.systemGray6-dark : CupertinoColors.systemGray4;
10597
out property <brush> bar-background: dark-color-scheme ? CupertinoColors.systemGray4-dark : CupertinoColors.systemGray4;
10698
out property <brush> bar-border: dark-color-scheme ? @linear-gradient(180deg, CupertinoColors.systemGray4-dark 0%, CupertinoColors.systemGray3-dark 80%, CupertinoColors.systemGray2-dark 100%) : CupertinoColors.systemGray5;
107-
out property <brush> inner-border: dark-color-scheme ? CupertinoColors.systemGray5-dark: CupertinoColors.systemGray4;
99+
out property <brush> inner-border: dark-color-scheme ? CupertinoColors.systemGray5-dark : CupertinoColors.systemGray4;
108100
out property <brush> inner-shadow: dark-color-scheme ? CupertinoColors.systemGray5-dark : CupertinoColors.systemGray6;
109101

110102
out property <brush> state: dark-color-scheme ? CupertinoColors.systemGray6 : CupertinoColors.systemGray6-dark;

0 commit comments

Comments
 (0)