Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the order of the indicator implementations fallback #502

Open
pacho2 opened this issue Jan 20, 2023 · 1 comment
Open

Change the order of the indicator implementations fallback #502

pacho2 opened this issue Jan 20, 2023 · 1 comment
Labels

Comments

@pacho2
Copy link

pacho2 commented Jan 20, 2023

Currently trayicon plugin will try to load old libappindicator implementation and, if not found, fallback to the new one:

    gi.require_version('AppIndicator3', '0.1')
    from gi.repository import AppIndicator3 as appindicator
except:
    #fall back to Ayatana
    gi.require_version('AyatanaAppIndicator3', '0.1')
    from gi.repository import AyatanaAppIndicator3 as appindicator

the problem is that, during the transition, it is common to have both installed (as they can be installed at the same time) and, then, it will keep using the old (unmaintained) version over the new one.

I would then reverse the logic to fallback to the old implementation if ayatana one is not present

Thanks a lot

@pacho2 pacho2 added the bug label Jan 20, 2023
@AdamPS
Copy link
Collaborator

AdamPS commented Dec 22, 2023

Great it seems that you know what the fix is. If you could create a pull request and test it works for you then we can merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants