Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Map should fit better to Slovenia on initial load #96 #98

Closed
wants to merge 2 commits into from

Conversation

jalezi
Copy link
Collaborator

@jalezi jalezi commented Dec 15, 2021

No description provided.

@jalezi jalezi requested a review from stefanb December 15, 2021 08:53
@jalezi jalezi linked an issue Dec 15, 2021 that may be closed by this pull request
@stefanb
Copy link
Member

stefanb commented Dec 15, 2021

I don't think specifying a map zoom for specific breakpoints is the right approach, as it does not scale well, literally:
image
image
image
image

@jalezi
Copy link
Collaborator Author

jalezi commented Dec 15, 2021

I didn't try to set zoom for larger screens while I was not sure if it's the right approach :).

I have tried with fitbounds. Could not find good solution.

I guess it will have to wait while it might need more complex changes . I am not even sure if I am able to solve it without any help from more experienced react dev.

For mobile landscape I am not sure if we can find satisfying solution at all. Maybe with new design (on mobile with map/cards switch) and hiding header the map height will be big enough. Not sure if we should pay attention at all or at least not ATM.

@jalezi
Copy link
Collaborator Author

jalezi commented Dec 22, 2021

Poor attempt.

@jalezi jalezi closed this Dec 22, 2021
@jalezi
Copy link
Collaborator Author

jalezi commented Dec 22, 2021

Poor attempt.

@jalezi jalezi deleted the fix/mobile-zoom branch December 22, 2021 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile: Map should fit better to Slovenia on initial load
3 participants