-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeORM types required #10
Comments
Thank you for the issue. I confirmed that it produces errors as pointed out. |
I have changed to use |
Hi, I've tested out the latest I'm not familiar enough with this issue to have any better suggestions. Fixing it isn't critical to me, especially since there's a workaround, so don't worry if you can't find a solution. |
@baumandm Thank you for trying it. Are you using TypeScript 3.8 or later? |
We faced the same issue on |
Same issue on "type-graphql-dataloader": "^0.3.7". Typescript version is 3.8.3 |
Is it still the case at the latest version ( |
Not using TypeORM either, so resolving this would help us out as well. Could still reproduce this with
|
Thank you for reporting. |
Hi, I am trying to use this library without the optional TypeORM support, but building the project fails:
Since I'm not using TypeORM, I don't want to add a dependency on it just to provide these types. I've worked around this by creating a
typeorm.d.ts
file and manually stubbing those types:Ideally I wouldn't have to do this. This link has some possible solutions to solve this: https://stackoverflow.com/questions/54392809/how-do-i-handle-optional-peer-dependencies-when-publishing-a-typescript-package
The text was updated successfully, but these errors were encountered: