Skip to content

Commit f196c2e

Browse files
committed
Remove faulty test, add comment for future inclusion
1 parent 26640a6 commit f196c2e

File tree

1 file changed

+6
-10
lines changed

1 file changed

+6
-10
lines changed

pydm/tests/data_plugins/test_p4p_plugin_component.py

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,7 @@ def generate_control_variables(value):
5151
1,
5252
),
5353
(NTEnum().wrap({"index": 0, "choices": ["YES", "NO", "MAYBE"]}), False, 0, 2),
54-
(NTScalar("i").wrap({"value": np.int32(10)}), False, np.int32(10), 1),
55-
],
54+
], # Add cases for testing NTTable containing np.integer and np float types arrays here
5655
)
5756
def test_send_new_value(
5857
monkeypatch: MonkeyPatch,
@@ -79,14 +78,11 @@ def receive_signal(value_name: str, value_received: object):
7978
nonlocal signals_received
8079
signals_received += 1
8180

82-
if isinstance(value_to_send, np.integer):
83-
expected_value_type = type(np.integer)
84-
else:
85-
expected_value_type = type(value_to_send.value)
86-
if isinstance(value_to_send.value, list):
87-
expected_value_type = np.ndarray
88-
elif "NTEnum" in value_to_send.getID():
89-
expected_value_type = int
81+
expected_value_type = type(value_to_send.value)
82+
if isinstance(value_to_send.value, list):
83+
expected_value_type = np.ndarray
84+
elif "NTEnum" in value_to_send.getID():
85+
expected_value_type = int
9086

9187
p4p_connection.new_value_signal[expected_value_type].connect(functools.partial(receive_signal, "value"))
9288
p4p_connection.lower_alarm_limit_signal.connect(functools.partial(receive_signal, "low_alarm_limit"))

0 commit comments

Comments
 (0)