Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unsafe_route metric / hop count #353

Open
Mrc527 opened this issue Dec 22, 2020 · 7 comments · May be fixed by #1332
Open

Add unsafe_route metric / hop count #353

Mrc527 opened this issue Dec 22, 2020 · 7 comments · May be fixed by #1332
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@Mrc527
Copy link

Mrc527 commented Dec 22, 2020

Hello guys,

In my scenario, I've multiple nodes which could serve the same unsafe route.
Let's say, I want to access a TV on my local network and I've nebula nodes on my NAS and Router. Both on the same local network.

So, while being on the road, I could connect to the TV through the NAS or the Router. But since the NAS is more powerful, I get a better bandwidth if I go through it rather than the Router.

I would like to have an option in the unsafe_routes to specify a priority like:

unsafe_routes:
    - route: 192.168.1.0/24
      via: 192.168.99.1
      priority: 1
    - route: 192.168.1.0/24
      via: 192.168.99.2
      priority: 2

So, my nebula client should first try to reach 192.168.1.0 network through 192.168.99.1 and, if 192.168.99.1 is not reachable, start looking for 192.168.99.2.

How do you see it?

Ciao!
M
@hulucc
Copy link

hulucc commented Jan 19, 2021

Same requirement but I want to do unsafe_routes high availability.

@ton31337
Copy link
Contributor

Related: #474

@wadey wadey modified the milestone: v1.5.0 Nov 2, 2021
@wadey
Copy link
Member

wadey commented Nov 5, 2021

#474 was merged, so closing this issue.

@wadey wadey closed this as completed Nov 5, 2021
@dhananjays
Copy link

dhananjays commented Mar 13, 2023 •
edited
Loading

Is this issue really addressed by #474 ?
It seems like that only supports the case where the two routes are via different interfaces (eg. one via openVpn while another via nebula)

When we are trying to define both routes via nebula (similar to the routes mentioned by OP #353 (comment)), we are seeing that whichever route is later in the config gets used (irrespective of value of metric). We are using v1.6.1

CC: @hulucc @Mrc527 Is your use-case working with 1.6.1?

@dhananjays
Copy link

@wadey I think this issue isn't addressed by #474. Can you please reopen this issue?

@wadey wadey reopened this Apr 27, 2023
@wadey wadey removed this from the v1.5.0 milestone Apr 27, 2023
@johnmaguire johnmaguire added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 1, 2023
@undo-alex
Copy link

Is this issue really addressed by #474 ? It seems like that only supports the case where the two routes are via different interfaces (eg. one via openVpn while another via nebula)

When we are trying to define both routes via nebula (similar to the routes mentioned by OP #353 (comment)), we are seeing that whichever route is later in the config gets used (irrespective of value of metric). We are using v1.6.1

CC: @hulucc @Mrc527 Is your use-case working with 1.6.1?

Hi. We are trying to get use of metric feature in unsafe_routes and we see the same issue as dhananjays in version 1.6.1 and 1.7.0.

Any idea if this is going to be looked at? Thank you

@johnmaguire
Copy link
Collaborator

Hi @undo-alex and @dhananjays - the best way to let the team know this issue is a priority to you is to give the original issue a 👍 reaction. This way we can sort issues by votes. Thank you!

@johnmaguire johnmaguire linked a pull request Mar 7, 2025 that will close this issue
Open
@johnmaguire johnmaguire linked a pull request Mar 7, 2025 that will close this issue
Implement ECMP for unsafe_routes #1332
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement ECMP for unsafe_routes dioss-Machiel/nebula
7 participants
@wadey @johnmaguire @Mrc527 @dhananjays @ton31337 @hulucc @undo-alex