Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix how tests run so we don't rely on assume_php #1

Open
mwildehahn opened this issue Jul 25, 2019 · 4 comments
Open

Fix how tests run so we don't rely on assume_php #1

mwildehahn opened this issue Jul 25, 2019 · 4 comments

Comments

@mwildehahn
Copy link

Currently tests rely on:

  • parsing a JSON schema
  • generating a validator from it
  • using that validator to execute tests

If these test files are marked as strict, it creates a chicken and egg problem. The class needs to exist before we can test it, but we need to run the tests to generate the validator. This is especially problematic when there is an error in the generated code while developing. It's often times useful to delete the currently generated file and regenerate it -- which only works if we have assume_php=true and set the files to // partial.

@fredemmott
Copy link

This is also absolutely required to support more recent versions of HHVM; assume_php was removed in 4.1

@lexidor
Copy link
Contributor

lexidor commented Jan 27, 2020

This issue may be closed. We are not relying on assume_php.

@mwildehahn
Copy link
Author

Yup looks like you're right. Marking all these as // strict then I think we can close this: #31

@lexidor
Copy link
Contributor

lexidor commented Mar 14, 2020

@mwildehahn This issue may be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants