Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this doesn't seems right #344

Closed
mohammadkahelghi-grabtaxi opened this issue May 20, 2024 · 2 comments
Closed

this doesn't seems right #344

mohammadkahelghi-grabtaxi opened this issue May 20, 2024 · 2 comments

Comments

@mohammadkahelghi-grabtaxi
Copy link

mohammadkahelghi-grabtaxi commented May 20, 2024

https://github.com/slackhq/compose-lints/blob/f1ada1945d037e34b98ac9c33c89b0a99440b0e0/compose-lint-checks/src/test/java/slack/lint/compose/ContentEmitterReturningValuesDetectorTest.kt#L73C8-L81C17

 import androidx.compose.runtime.Composable

        @Composable
        fun Something() {
            Text("Hi")
            Text("Hola")
        }
        @Composable
        fun Something() {
            Spacer16()
            Text("Hola")
        }
        

function names are same with no args

@ZacSweers
Copy link
Collaborator

It doesn't compile but that's not necessarily required for lints. PR is welcome if you want to change it though

@ZacSweers
Copy link
Collaborator

Closing as this lacks context, feel free to revisit (with more detail)

@ZacSweers ZacSweers closed this as not planned Won't fix, can't repro, duplicate, stale Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants