Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shard request caching #715

Closed
bryanlb opened this issue Oct 30, 2023 · 1 comment
Closed

Add shard request caching #715

bryanlb opened this issue Oct 30, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@bryanlb
Copy link
Contributor

bryanlb commented Oct 30, 2023

Description

For requests that come through to a given shard that are identical to previous queries (think long-range queries, dashboarding, etc) these should use a request cache and not invoke Lucene. This is similar in concept to the shard request caching as described here https://www.elastic.co/blog/elasticsearch-caching-deep-dive-boosting-query-speed-one-cache-at-a-time but differs in techincal implementation due to our architecture.

A POC of this has been done here #714, but will need some additional considerations around how to handle the issue of extended bounds for date histograms, and any similar aggregation metadata fields. This POC did not perform as expected either, as the resulting queries did not see a significant speed improvements - we will need to add additional instrumentation for hit/miss ratios to ensure we are getting the expected hit ratios.

@bryanlb bryanlb added the enhancement New feature or request label Oct 30, 2023
Copy link

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Apr 28, 2024
@bryanlb bryanlb removed the Stale label Apr 29, 2024
@bryanlb bryanlb closed this as completed Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant