Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recovery tasks can create excessively large chunks, resulting in out of disk #663

Open
bryanlb opened this issue Sep 1, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@bryanlb
Copy link
Contributor

bryanlb commented Sep 1, 2023

Describe the bug

Recovery tasks are created based on message counts, which is a static config value. If this value is not correctly optimized, it can cause the cache nodes to download too much data and crash with an out-of-disk.

Expected behavior

There are several ways we could resolve this - the cache nodes could dynamically calculate and advertise slots based on available disk space; the recovery process could use disk size instead of message counts (somewhat complex to create tasks based on an anticipated size).

Of these options the former may be the most attractive, as it also accounts for the inverse issue where lots of small recovery tasks take up slots but not much disk space.

@bryanlb bryanlb added the bug Something isn't working label Sep 1, 2023
Copy link

github-actions bot commented Mar 7, 2024

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Mar 7, 2024
@bryanlb bryanlb removed the Stale label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant