Skip to content
This repository has been archived by the owner on Jun 14, 2022. It is now read-only.

what other headers should be ignored on replay matching and on replay triggering? #16

Open
aoberoi opened this issue Aug 17, 2017 · 1 comment
Open

what other headers should be ignored on replay matching and on replay triggering? #16

aoberoi opened this issue Aug 17, 2017 · 1 comment
Labels
discussion M-T: An issue where more input is needed to reach a decision

Comments

@aoberoi
Copy link
Contributor

aoberoi commented Aug 17, 2017

the host and date are examples of headers that will never be accurate when requests are matched or triggered. is that all? are there any others we should ignore? is there a whitelist?
@aoberoi aoberoi added question M-T: User needs support to use the project discussion M-T: An issue where more input is needed to reach a decision and removed question M-T: User needs support to use the project labels Aug 17, 2017
@aoberoi
Copy link
Contributor Author

aoberoi commented Sep 15, 2017

let's not record Content-Length. i just wasted a day of development trying to redact a sensitive string from a body, and then realized my server was completely dropping the request from steno because the Content-Length was wrong. when i simply removed that header, it went through fine. for reference, the server was written using node.js and express.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
discussion M-T: An issue where more input is needed to reach a decision
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aoberoi