Fix #709 Enable developers to inject non-bolt arguments to listener function args #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stener function args
seratch
commented
Aug 25, 2022
| logger.warning(f"Unknown Request object type detected ({type(request)})") | ||
|
|
||
| if name not in found_arg_names: | ||
| logger.warning(f"{name} is not a valid argument") | ||
| kwargs[name] = None |
There was a problem hiding this comment.
To allow developers to inject extra args, we remove this logic
| logger.warning(f"Unknown Request object type detected ({type(request)})") | ||
|
|
||
| if name not in found_arg_names: | ||
| logger.warning(f"{name} is not a valid argument") | ||
| kwargs[name] = None |
There was a problem hiding this comment.
To allow developers to inject extra args, we remove this logic
| @@ -81,8 +83,9 @@ def __call__( | |||
| found_arg_names = kwargs.keys() | |||
| for name in self.arg_names: | |||
| if name not in found_arg_names: | |||
| self.logger.warning(f"{name} is not a valid argument") | |||
| kwargs[name] = None | |||
There was a problem hiding this comment.
To allow developers to inject extra args, we remove this logic
| @@ -77,8 +79,9 @@ async def __call__( | |||
| found_arg_names = kwargs.keys() | |||
| for name in self.arg_names: | |||
| if name not in found_arg_names: | |||
| self.logger.warning(f"{name} is not a valid argument") | |||
| kwargs[name] = None | |||
There was a problem hiding this comment.
To allow developers to inject extra args, we remove this logic
|
This pull request is still in progress. Existing tests detected regressions. |
|
After looking into this more deeply, I concluded this enhancement is not feasible. Even if it's feasible in some way, I don't think it's maintainable for us. Let me close this my proposal here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves #709
Category (place an
xin each of the[ ])slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsslack_bolt.adapter/docsRequirements (place an
xin each[ ])Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.