Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytype execution fails when using install_all_and_run_tests.sh #1099

Closed
srtaalej opened this issue Jun 25, 2024 · 3 comments · Fixed by #1100
Closed

pytype execution fails when using install_all_and_run_tests.sh #1099

srtaalej opened this issue Jun 25, 2024 · 3 comments · Fixed by #1100
Labels
dependencies Pull requests that update a dependency file tests

Comments

@srtaalej
Copy link

srtaalej commented Jun 25, 2024

I ran $ ./scripts/install_all_and_run_tests.sh (as per the maintainers guide) and received:

ninja: Entering directory `.pytype'
[101/192] check slack_bolt.middleware.async_custom_middleware
FAILED: /Users/maria.mercado/bolt-python/.pytype/pyi/slack_bolt/middleware/async_custom_middleware.pyi 
/Users/maria.mercado/bolt-python/env_3.8.5/bin/python3 -m pytype.main --imports_info /Users/maria.mercado/bolt-python/.pytype/imports/slack_bolt.middleware.async_custom_middleware.imports --module-name slack_bolt.middleware.async_custom_middleware --platform darwin -V 3.9 -o /Users/maria.mercado/bolt-python/.pytype/pyi/slack_bolt/middleware/async_custom_middleware.pyi --analyze-annotated --nofail --quick /Users/maria.mercado/bolt-python/slack_bolt/middleware/async_custom_middleware.py
File "/Users/maria.mercado/bolt-python/slack_bolt/middleware/async_custom_middleware.py", line 45, in async_process: Function <callable> expects 1 arg(s), got 0 [wrong-arg-count]
         Expected: (_)
  Actually passed: ()

For more details, see https://google.github.io/pytype/errors.html#wrong-arg-count
ninja: build stopped: subcommand failed.
Leaving directory '.pytype'

i made changes to several README and .md files (working on issue #777) but @zimeg also ran the test script and got the same error

@seratch seratch added dependencies Pull requests that update a dependency file tests labels Jun 25, 2024
@seratch
Copy link
Member

seratch commented Jun 25, 2024

Hi @srtaalej, thanks for reporting this! I will check this out later. When you're only working on the docs, you don't need to run Python tests at all. So, you can ignore this for now 👋

@seratch
Copy link
Member

seratch commented Jun 25, 2024

By the way, can you share a bit more details on the steps? We have an issue template for bug reports: https://github.com/slackapi/bolt-python/blob/main/.github/ISSUE_TEMPLATE/04_bug.md

@seratch
Copy link
Member

seratch commented Jun 25, 2024

bolt-python/env_3.8.5

Ah, you're using Python 3.8.5. Perhaps, this would be enough for this report

seratch added a commit to seratch/bolt-python that referenced this issue Jun 25, 2024
seratch added a commit to seratch/bolt-python that referenced this issue Jun 25, 2024
@seratch seratch changed the title Async middleware test failure pytype execution fails when using install_all_and_run_tests.sh Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants