Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-nevado topic messages are not being cleaned up #85

Open
carterpage opened this issue May 23, 2014 · 1 comment
Open

Non-nevado topic messages are not being cleaned up #85

carterpage opened this issue May 23, 2014 · 1 comment

Comments

@carterpage
Copy link
Member

The implementation checks if the destination is of type NevadoTopic before it deletes the message. It should probably check that it is "Topic" in case it is a non-Nevado topic.

public class NevadoSession implements Session {
 .......
 protected NevadoMessage receiveMessage(NevadoDestination destination, long timeoutMs, boolean noLocal)
            throws JMSException, InterruptedException {

       …….

        // Filter noLocal matches
 line 437:  if (message != null && destination instanceof NevadoTopic && noLocal && _connection.getConnectionID()
                .equals(message.getNevadoProperty(NevadoProperty.ConnectionID)))
        {
            deleteMessage(message);
            message = null;
        }
    }

   ……..
}

.....

}

@carterpage
Copy link
Member Author

Unable to reproduce. Whenever NevadoSession creates a consumer or a producer with a foreign implementation of a Destination, it will transform it into a NevadoDestination using NevadoDestination.getInstance(destination);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant