Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Flux Error #574

Open
philipp128 opened this issue Sep 20, 2022 · 0 comments
Open

ENH: Flux Error #574

philipp128 opened this issue Sep 20, 2022 · 0 comments
Labels
enhancement Improvement of existing feature module: photometry

Comments

@philipp128
Copy link
Contributor

Description

Adapt the magnitude_error_rykoff function with an option to return flux errors.

Suggestion

  • I suggest renaming the function and add an option for either sampling the magnitude or the flux error.
  • I think the magnitude input parameter can stay the same, i.e. I do not think it is necessary to make flux an input

Outputs

The function should be able to return the flux or the magnitude error based on the Rykoff+15 model.

References

Reikoff+15: https://arxiv.org/abs/1509.00870
@philipp128 philipp128 added the enhancement Improvement of existing feature label Sep 20, 2022
@philipp128 philipp128 self-assigned this Sep 20, 2022
@philipp128 philipp128 changed the title Flux Error ENH: Flux Error Sep 20, 2022
@philipp128 philipp128 removed their assignment Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement of existing feature module: photometry
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@philipp128