Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add in remaining stellar mass quantitiy #543

Open
WillHartley opened this issue May 9, 2022 Discussed in #536 · 0 comments
Open

ENH: Add in remaining stellar mass quantitiy #543

WillHartley opened this issue May 9, 2022 Discussed in #536 · 0 comments
Assignees
Labels
enhancement Improvement of existing feature module: galaxies

Comments

@WillHartley
Copy link

Discussed in #536

Originally posted by WillHartley March 24, 2022
In the k-correct templates we have the mass in stars formed, and the mass remaining (after mass loss due to stellar winds, SNe etc.).
We're preparing a PR to allow use of stellar mass remaining. Current behaviour is that the function, stellar_mass(), refers to stellar mass formed. IMO, the default should be to return the remaining stellar mass.

Proposal:
We have two functions,
stellar_mass_formed()
stellar_mass_remain()

Then the function,
stellar_mass()
simply calls stellar_mass_remain()

Following the discussion, we cannot change the meaning of stellar_mass(), and so we will need to simply add a stellar_mass_remain() function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing feature module: galaxies
Projects
None yet
Development

No branches or pull requests

2 participants