Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Job] Wrong Exception Handling For Dashboard #4539

Open
KeplerC opened this issue Jan 7, 2025 · 1 comment
Open

[Job] Wrong Exception Handling For Dashboard #4539

KeplerC opened this issue Jan 7, 2025 · 1 comment

Comments

@KeplerC
Copy link
Collaborator

KeplerC commented Jan 7, 2025

The exception thrown by the dashboard.py is misleading

it throws Cluster does not exist in all cases.

To reproduce

ssh sky-jobs-controller-hash 
curl localhost:5000  # normal response
cd ~/.sky && mv sky_ray.yml sky_ray.yml_ # introduce a simple bug 
curl localhost:5000 
cat ~/.sky/job-dashboard.log 

Error log:

~/.sky$ cat ~/.sky/job-dashboard.log 
 * Serving Flask app 'dashboard'
 * Debug mode: off
INFO:werkzeug:WARNING: This is a development server. Do not use it in a production deployment. Use a production WSGI server instead.
 * Running on http://127.0.0.1:5000
INFO:werkzeug:Press CTRL+C to quit
INFO:werkzeug:127.0.0.1 - - [07/Jan/2025 02:02:09] "GET / HTTP/1.1" 200 -
ERROR:dashboard:Exception on / [GET]
sky.exceptions.ClusterDoesNotExist: Cluster 'sky-jobs-controller-726f1974' does not exist.

it throws cluster does not exists in any circumstances.

  • sky -v: PLEASE_FILL_IN
  • sky -c: PLEASE_FILL_IN
@Mizokuiam
Copy link

Thank you for raising this issue! I'll look into it and try to help if I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants