Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support native RSpec example filtering #23

Open
ianks opened this issue Aug 26, 2020 · 1 comment · May be fixed by #47
Open

Support native RSpec example filtering #23

ianks opened this issue Aug 26, 2020 · 1 comment · May be fixed by #47
Labels
enhancement New feature or request

Comments

@ianks
Copy link

ianks commented Aug 26, 2020

For test performance, we split our suite into acceptance and unit tests. We do this because acceptance spec require static assets to be built, which takes a decent amount of time which, whereas unit specs can be run instantly. We accomplish this with RSpec tags. For example, here is how we run our acceptance tests using rspec-queue:

            bin/_rspec-queue \
              --namespace acceptance \
              --tag capybara_feature \
              --tag type:feature \
              --tag type:request \
              --tag js \
              --tag webpack \
              --format=doc \
              --format=RspecJunitFormatter \
              --out="tmp/test_results/rspec_acceptance/results-$CIRCLE_NODE_INDEX.xml" \
              --requeue-tolerance=0.05 \
              --max-requeues="$CIRCLE_NODE_TOTAL"

In order to use rspecq, we need to mimic this functionality. As of now, it does not seem like rspecq supports example filtering, is this right? If not, would it be possible to support this use case?

@agis agis added the enhancement New feature or request label Aug 26, 2020
@agis
Copy link
Collaborator

agis commented Aug 27, 2020

Right, currently we don't support passing tags, simply because we haven't encountered the need to. It's certainly a valid feature though. I guess it would involve somehow passing the tags argument in here, similar to how we pass --format:

opts = RSpec::Core::ConfigurationOptions.new(["--format", "progress", job])

The CLI should also be extended to support this argument.

@jacobthemyth jacobthemyth linked a pull request Dec 6, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants