Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consumer: Support consuming from multiple topics #5

Open
agis opened this issue Jul 18, 2017 · 0 comments · May be fixed by #17
Open

consumer: Support consuming from multiple topics #5

agis opened this issue Jul 18, 2017 · 0 comments · May be fixed by #17
Assignees
@fragoulis
Labels
enhancement

Comments

@agis
Copy link
Contributor

agis commented Jul 18, 2017

Rafka already supports this so we should also support it. Ideally, #consume should accept the topic(s) as an argument.
@fragoulis fragoulis self-assigned this Apr 18, 2019
fragoulis added a commit that referenced this issue Apr 18, 2019
@fragoulis
Pluralize the :topic initialization option
76c6705 
By default, kafka and kafka-go support consumers subscribing to
multiple topics, by passing an array of strings.

Rafka also respects this (see server.go#parseTopicsAndConfig).

Rafka-rb simply needs to change the wording in order to respect
the plural and in effect show the api user that consuming from
multiple topics is supported.

The commit takes the extra step of supporting an array of strings
as well as a single string, whether it contains a single topic or
multiple comma-separated topics.

Closes #5
@fragoulis fragoulis linked a pull request Apr 18, 2019 that will close this issue
Open
fragoulis added a commit that referenced this issue Apr 18, 2019
@fragoulis
Pluralize the :topic initialization option
dbcd6c9 
By default, kafka and kafka-go support consumers subscribing to
multiple topics, by passing an array of strings.

Rafka also respects this (see server.go#parseTopicsAndConfig).

Rafka-rb simply needs to change the wording in order to respect
the plural and in effect show the api user that consuming from
multiple topics is supported.

The commit takes the extra step of supporting an array of strings
as well as a single string, whether it contains a single topic or
multiple comma-separated topics.

Closes #5
fragoulis added a commit that referenced this issue Apr 18, 2019
@fragoulis
Pluralize the :topic initialization option
eb2a030 
By default, kafka and kafka-go support consumers subscribing to
multiple topics, by passing an array of strings.

Rafka also respects this (see server.go#parseTopicsAndConfig).

Rafka-rb simply needs to change the wording in order to respect
the plural and in effect show the api user that consuming from
multiple topics is supported.

The commit takes the extra step of supporting an array of strings
as well as a single string, whether it contains a single topic or
multiple comma-separated topics.

Closes #5
fragoulis added a commit that referenced this issue Apr 18, 2019
@fragoulis
Pluralize the :topic initialization option
78ae428 
By default, kafka and kafka-go support consumers subscribing to
multiple topics, by passing an array of strings.

Rafka also respects this (see server.go#parseTopicsAndConfig).

Rafka-rb simply needs to change the wording in order to respect
the plural and in effect show the api user that consuming from
multiple topics is supported.

The commit takes the extra step of supporting an array of strings
as well as a single string, whether it contains a single topic or
multiple comma-separated topics.

Closes #5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fragoulis fragoulis

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pluralize the :topic initialization option skroutz/rafka-rb
2 participants
@agis @fragoulis